Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

django-image-cropping not working in Django 2.x #117

Open
Seykotron opened this issue Aug 18, 2019 · 4 comments
Open

django-image-cropping not working in Django 2.x #117

Seykotron opened this issue Aug 18, 2019 · 4 comments

Comments

@Seykotron
Copy link

Hi,

I'm getting crazy with this, using the same code as the Demo, and the frontend part of cropping not working.

There is no error in Inspect Elements, the jQuery is loading fine etc, I dont know what it can be, any guesses?

Thank you!!!
Captura de pantalla 2019-08-18 a las 15 25 47

@oscarmlage oscarmlage added the bug label Aug 20, 2019
@oscarmlage oscarmlage added this to the next release milestone Aug 20, 2019
@oscarmlage
Copy link
Owner

Yeah @Seykotron you're right. Right now the django-image-cropping package is not working 😢.

We need to work in the last version integration. Had it tested and running with Django 1.x but it crashed with 2.x. I saw django-image-cropping has now support for Django 2.1 so the code needs to be updated (probably in the next release). Thanks for noticing.

@Seykotron
Copy link
Author

Let me know if I can give you a hand to fix it, I need this feature hehehe

I also have some modifications in the code for example let __icontains in filter_list, I think it can be very usefull :)

@oscarmlage
Copy link
Owner

Hey @Seykotron, cropping is working here in Demo project with Django==2.2.3 + django-image-cropping==1.2.0

image

Please give a look to your environment versions and let me know if it works there. Also if it doesn't please try to prepare something like a demo-project or some bundle that I could download and run here in my environments.

@oscarmlage
Copy link
Owner

I was fifty-fifty wrong in last comment. It is working if you edit/update a record that already has the image, but it is not working if you're adding a new record.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants