Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

float() use should be replaced with version.parse() #313

Open
bcl opened this issue Apr 16, 2024 · 0 comments
Open

float() use should be replaced with version.parse() #313

bcl opened this issue Apr 16, 2024 · 0 comments

Comments

@bcl
Copy link

bcl commented Apr 16, 2024

float values are not safe for comparisons, especially equality. They should not be used for version (or really, anything other than math). This codebase is already using packaging.version's parse for some of the version handling. The floats should be converted to do this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant