Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic error in embedded-control error model states #8

Open
pbalsgaard opened this issue Mar 16, 2017 · 0 comments
Open

Logic error in embedded-control error model states #8

pbalsgaard opened this issue Mar 16, 2017 · 0 comments

Comments

@pbalsgaard
Copy link

pbalsgaard commented Mar 16, 2017

According to documentation the systems needs at least two operational sensors and at least one operational actuator. The logic implemented says that at least one operational actuator makes the system operational, and at least one failed actuator makes the system failed, so a condition can exist that makes the system operational and failed at the same time. This error also exists in the wiki.sei.cmu.edu page referenced in the model.

[(at least two sensors operational) or (a1.Operational or a2.Operational)]-> Operational;
[a1.Failed or a2.Failed]-> Failed;

Should be:
[(at least two sensors operational) and (a1.Operational or a2.Operational)]-> Operational;
[a1.Failed and a2.Failed]-> Failed;

osate/examples/embedded-control/aadl-model/embedded-control-advanced.aadl lines 283-284
osate/examples/embedded-control/aadl-model/embedded-control.aadl lines 217-218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant