Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configurable colors (themes) #4

Open
orlangure opened this issue Jan 30, 2022 · 5 comments
Open

Support configurable colors (themes) #4

orlangure opened this issue Jan 30, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@orlangure
Copy link
Owner

No description provided.

@orlangure orlangure added the enhancement New feature or request label Jan 30, 2022
@bashbunni
Copy link
Contributor

Hey! I'm working on this right now and I'm curious as to how we want the users to set their theme? Would we have a flag for it that you need to run each time or write to some gocovsh config file in .config/gocovsh

@bashbunni
Copy link
Contributor

an environment variable would probably be the easiest

@bashbunni bashbunni mentioned this issue Nov 5, 2022
1 task
@bashbunni
Copy link
Contributor

I created a PR that works with an environment variable. The thing is, it's not fully working. I'm getting a nil pointer error - shown in the demo GIF attached to the PR

@thelooter
Copy link

Are further contributions adding themes welcome? Or should a more modular approach, which doesn't require adding Code for every new theme, be used?

@orlangure
Copy link
Owner Author

Hey @thelooter and sorry for taking so long to respond here.

Theme and other contributions are welcome. I have a task somewhere to support configurable theme files so that no code changes are required to customize the looks, but it would require refactoring of existing code.

I'll be happy to accept both "hard coded" themes and externally configurable themes if you still wish to work on this.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

3 participants