Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow the spec #97

Open
4 tasks
GuiltyDolphin opened this issue Jun 25, 2021 · 0 comments
Open
4 tasks

Follow the spec #97

GuiltyDolphin opened this issue Jun 25, 2021 · 0 comments

Comments

@GuiltyDolphin
Copy link
Contributor

GuiltyDolphin commented Jun 25, 2021

It would be great if we could rework the types to better follow the spec. Sure the spec is only a draft, but it should provide a good basis for making sure we aren't missing anything major :)

TODO Keywords

See https://orgmode.org/worg/dev/org-syntax.html#Affiliated_keywords.

Currently, keywords get parsed into an attributes field of elements, but this does not match the spec. Whilst I agree this is a useful transformation, we should be doing this as an optional post step - the AST should match the spec as closely as possible.

  • remove attributes field from AST items
  • provide an optional post transformation that assigns attributes to their corresponding objects
  • ensure only standard keys are supported by default
  • provide a parser option to allow additional keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant