Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github actions #58

Open
hardliner66 opened this issue Oct 10, 2023 · 2 comments · May be fixed by #62
Open

Add github actions #58

hardliner66 opened this issue Oct 10, 2023 · 2 comments · May be fixed by #62

Comments

@hardliner66
Copy link
Contributor

It should be quite easy to add some github actions to run the tests on each commit/PR and deploy the files to github pages, if the build was successful. This would guarantee that contributions don't break tests and that people can simply test the VM directly in the browser without having to manually compile it.

@dalnefre
Copy link
Contributor

dalnefre commented Oct 16, 2023

I believe that some of the recent improvement to the automated test infrastructure by @jamesdiacono should make this easier. I'd love to see an automatically-updated github-hosted uFork VM debugger instance.

@hardliner66
Copy link
Contributor Author

I was recently trying to get github pages to work, but they don't set the wasm mime type properly, so I need to work around that somehow. I'll check how trunk or wasm-pack loads the wasm, because I know they work on pages.

I can testing for that too, so that only fully tested code gets pushed to pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants