Exposing when bellhop.exe is not recognized

[ctuguinay]

Hey ARL team,

I was trying to use .compute_eigenrays and nothing actually happened (which was indicated by .plot_rays error-ing out), and then I tried again with debug turned on and all I got was:

[DEBUG] Model: bellhop
[WARN] Bellhop did not generate expected output file

This was not too helpful in the debugging process.

I was looking back at the code to see where bellhop.exe is called and I printed out the result of _proc.run of bellhop and got the following:

CODE:

    def _bellhop(self, *args):
        try:
            result = _proc.run(f'bellhop.exe {" ".join(list(args))}',
                            stderr=_proc.STDOUT, stdout=_proc.PIPE,
                            shell=True)
            print(result)

OUTPUT:

CompletedProcess([Some other args here with personal paths].......returncode=1, stdout=b"'bellhop.exe' is not recognized as an internal or external command,\r\noperable program or batch file.\r\n")

With this message, I was able to fix the problem (which ended up being a path issue to bellhop.exe), but I wonder now if stdout when returncode=1 should be exposed to the user during debug is True or just raised as some sort of warning? If any of these sound good, I'd be willing to submit a PR with this proposed change.

Edit: I tested this via the bellhop.ipynb notebook, so perhaps these messages are exposed in python scripts?

[mchitre]

Yes, a warning when something fails would be good. Happy to accept a PR.