Allow for configurable number of shards #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why it is not merged? It is an obvious improvement in usability |
sparrc
force-pushed
the
configurable-shard-count
branch
from
3634849
to
090d0ae
Compare
|
done :) |
sparrc
force-pushed
the
configurable-shard-count
branch
from
090d0ae
to
fc0dfb6
Compare
sparrc
force-pushed
the
configurable-shard-count
branch
from
fc0dfb6
to
ef5ac72
Compare
|
the merge conflicts are a bit beyond me....if anyone else wants to re-submit this change then feel free, I don't have time at the moment to resolve the conflicts |
|
@sparrc Thanks a lot for your assitance, I think that right now using a configurable number of shards might cause some issues, @redbaron pull requests address the issues but not completely. I hope that in the future we can implement your code in concurrent map. Once again, thanks for your ideas and implementations. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #17
allows for users to get a concurrent map with a configurable number of shards
made it an optional "list" so that the .New() call signature doesn't change.
I've also set SHARD_COUNT to be a constant. This could break people, but I think it's better for users not to be modifying globals to change the libraries behavior.