Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: document PackManifestOptions to make PackManifest reproducible #749

Merged
merged 4 commits into from
May 20, 2024
Merged

docs: document PackManifestOptions to make PackManifest reproducible #749

merged 4 commits into from
May 20, 2024

Conversation

wangxiaoxuan273
Copy link
Contributor

Resolves #748

@codecov Codecov
Copy link

codecov bot commented Apr 23, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.92%. Comparing base (c071bed) to head (961075d).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #749   +/-   ##
=======================================
  Coverage   77.92%   77.92%           
=======================================
  Files          63       63           
  Lines        4694     4694           
=======================================
  Hits         3658     3658           
  Misses        656      656           
  Partials      380      380

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Wwwsylvia
Wwwsylvia requested changes Apr 23, 2024
View reviewed changes
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to rephrase the related comment a bit for ExamplePackManifest_imageV10 and ExamplePackManifest_imageV11 in example_pack_test.go.

pack.go Outdated Show resolved Hide resolved
pack.go Outdated Show resolved Hide resolved
pack.go Show resolved Hide resolved
@Wwwsylvia
Copy link
Member

BTW, the PR title should start with docs (end with s) as per the conventional commit guidance. 😀

shizhMSFT
shizhMSFT reviewed Apr 30, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update the examples in example_pack_test.go.

pack.go Outdated Show resolved Hide resolved
pack.go Outdated Show resolved Hide resolved
@wangxiaoxuan273 wangxiaoxuan273 changed the title doc: document PackManifestOptions to make PackManifest reproducible docs: document PackManifestOptions to make PackManifest reproducible May 6, 2024
@wangxiaoxuan273
Copy link
Contributor Author

We also need to rephrase the related comment a bit for ExamplePackManifest_imageV10 and ExamplePackManifest_imageV11 in example_pack_test.go.

updated the comments in example_pack_test.go.

Wwwsylvia
Wwwsylvia reviewed May 7, 2024
View reviewed changes
example_pack_test.go Outdated Show resolved Hide resolved
Wwwsylvia
Wwwsylvia reviewed May 7, 2024
View reviewed changes
pack.go Outdated Show resolved Hide resolved
shizhMSFT
shizhMSFT reviewed May 7, 2024
View reviewed changes
pack.go Outdated Show resolved Hide resolved
pack.go Show resolved Hide resolved
shizhMSFT
shizhMSFT approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Wwwsylvia
Wwwsylvia approved these changes May 19, 2024
View reviewed changes
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangxiaoxuan273
doc: document PackManifestOptions to make PackManifest reproducible
2688d93 
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
@wangxiaoxuan273
resolved comments
4368405 
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
@wangxiaoxuan273
resolved comment
06bbe80 
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
@wangxiaoxuan273
resolved comments
961075d 
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Wwwsylvia
Wwwsylvia approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit aef90e4 into oras-project:main May 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wwwsylvia Wwwsylvia Wwwsylvia approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker SteveLasker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: document PackManifestOptions to make PackManifest reproducible
3 participants
@wangxiaoxuan273 @Wwwsylvia @shizhMSFT