Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor createEnvironmentFromBlueprint to use convention #41

Open
dilshat opened this issue Nov 1, 2017 · 0 comments
Open

Refactor createEnvironmentFromBlueprint to use convention #41

dilshat opened this issue Nov 1, 2017 · 0 comments
Assignees
@dilshat
Labels
fixed_in_dev

Comments

@dilshat
Copy link

dilshat commented Nov 1, 2017

the method createEnvironmentFromBlueprint is implemented differently from the other methods , it uses DTO whereas we use interface and client supplies implementations via factory methods.
To keep it consistent we need to refactor this method
@dilshat dilshat self-assigned this Nov 1, 2017
dilshat added a commit that referenced this issue Nov 1, 2017
@dilshat
#41
3f17167 
refactored method createEnvironmentFromBlueprint
also ignored tests involving pgp key manipulation b/c they started to fail, need more investigation, probably related to Linux Mint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dilshat dilshat

Labels
fixed_in_dev
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dilshat