New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Invisible Input Field for Promo Bar Message in Misc Tab of Release Coordinator #20294
Comments
Hi @Akhilesh-max! I'd love to take on this issue. |
Hi @sidharth-05, that would be great! Thanks. |
@sidharth-05 There's one more thing we need to ask you. Why is this bug happening in the first place -- what PR caused it? (See the "Tips for developers" in the issue description.) Understanding this is important to verify that what you propose is actually the correct fix, and not a hack. For the question about the dev server, please start a new thread in GitHub Discussions for it, and provide more details so that the dev workflow team can take a look at it. Thanks! |
@seanlip @Akhilesh-max After checking git blame, I believe the issue was caused from PR #18326. This was the most recent PR about an year ago. In this PR the 'Promo-bar config' changed to 'Enable Promo-Bar' and same for the Promo-Bar message. If in fact, this issue was not present while developing the release-coordinator-page.component.html file this must be the reason for the invisible field. But, nothing prompts me to think anything that was changed for the PR, would cause the issue though as none of the CSS code was changed only the names of the labels. |
Ah, good find, thanks -- I took a look at the video on that PR and the field is missing there, so I think you are probably right that this was an issue since the feature was introduced. /cc @lkbhitesh07 for info. One last thing to check: can you show a video/screenshot of the promo bar after your proposed changes? |
@seanlip Here is the video of the new update. Recording.11.mp4Lmk when I should make the PR. |
@sidharth-05 If I'm looking at the video correctly, the input field still doesn't seem visible before you click it? |
@seanlip Sorry I submitted the wrong video. Here is the correct one: Recording.12.mp4Changing the visibility was not the only issue it seems, because it would still disappear when you click out of it. So I just added a box on css for this the updates I made to the code are below. Lmk if any changes. |
@sidharth-05 I've assigned you, thanks. Go for it! |
Describe the bug
In the Misc tab of the Release Coordinator, there is an input field for entering the promo bar message. However, this input field is currently invisible, even though it can still receive input.
URL of the page where the issue is observed.
http://localhost:8181/release-coordinator#
Steps To Reproduce
Expected Behavior
The input field for the promo bar message should be clearly visible to users. Users should be able to see where they are entering their input.
Screenshots/Videos
Screen.Recording.2024-05-11.at.10.18.19.AM.mov
No response
What device are you using?
Desktop
Operating System
MacOS
What browsers are you seeing the problem on?
Chrome
Browser version
No response
Additional context
No response
Tips for developers
Before addressing the bug, please identify which PR caused the issue (you can follow the steps here). If you identify the PR, comment on the issue with a link to it. If not, mention the commit hash of the oldest commit you saw the bug on (and the month and year it was made in).
Then, please leave a comment with details of the approach that you plan to take to fix the issue (see example).
Note: If this is your first Oppia issue, please make sure to follow our guidelines for choosing an issue and setting things up. You will also need to show a demo of the fix working correctly on your local machine. Thanks!
The text was updated successfully, but these errors were encountered: