Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Invisible Input Field for Promo Bar Message in Misc Tab of Release Coordinator #20294

Open
Akhilesh-max opened this issue May 11, 2024 · 10 comments
Assignees
Labels
bug Label to indicate an issue is a regression frontend good first issue Work: Low Solution is known and broken into good-first-issue-sized chunks.

Comments

@Akhilesh-max
Copy link
Contributor

Akhilesh-max commented May 11, 2024

Describe the bug

In the Misc tab of the Release Coordinator, there is an input field for entering the promo bar message. However, this input field is currently invisible, even though it can still receive input.

URL of the page where the issue is observed.

http://localhost:8181/release-coordinator#

Steps To Reproduce

  • Navigate to the Release Coordinator.
  • Click on the Misc tab.
  • Try to enter a promo bar message in front of the text 'promo bar message'.
  • Notice that the input field is invisible, but still receives the input.

Expected Behavior

The input field for the promo bar message should be clearly visible to users. Users should be able to see where they are entering their input.

Screenshots/Videos

Screen.Recording.2024-05-11.at.10.18.19.AM.mov

No response

What device are you using?

Desktop

Operating System

MacOS

What browsers are you seeing the problem on?

Chrome

Browser version

No response

Additional context

No response

Tips for developers

Before addressing the bug, please identify which PR caused the issue (you can follow the steps here). If you identify the PR, comment on the issue with a link to it. If not, mention the commit hash of the oldest commit you saw the bug on (and the month and year it was made in).

Then, please leave a comment with details of the approach that you plan to take to fix the issue (see example).

Note: If this is your first Oppia issue, please make sure to follow our guidelines for choosing an issue and setting things up. You will also need to show a demo of the fix working correctly on your local machine. Thanks!

@Akhilesh-max Akhilesh-max added triage needed bug Label to indicate an issue is a regression labels May 11, 2024
animesh65432 added a commit to animesh65432/oppia that referenced this issue May 14, 2024
@AFZL210 AFZL210 added Work: Low Solution is known and broken into good-first-issue-sized chunks. frontend labels May 18, 2024
@sidharth-05
Copy link

Hi @Akhilesh-max! I'd love to take on this issue.

@Akhilesh-max
Copy link
Contributor Author

Hi @sidharth-05, that would be great!
However, before do we assign you, according to the guidelines, it would be really helpful if you could provide a brief explanation of what your PR will do. This includes the names of the files you’re planning to change and what modifications you intend to make in each file. If everything looks good, we’d be more than happy to assign you to this issue.

Thanks.

@sidharth-05
Copy link

sidharth-05 commented May 20, 2024

@Akhilesh-max

To resolve the issue of the input field being invisible, I can simply add the ‘visibility: visible;’ property to ensure the text is displayed correctly. This adjustment should be made in the relevant CSS section for the oppia-promo-bar-config-field class.

FilePath: oppia/core/templates/pages/release-coordinator-page/release-coordinator-page.component.html’

With this change, the input should be visible and not hidden. If this is not the issue most likely it is a problem in the HTML Structure.

If all is well, PR should be made in 1-2 days.

Screenshot 2024-05-19 at 7 51 49 PM

Final question: I also wanted to ask whether anyone has addressed a way to speed up the time to start the developer server? Currently, it seems to take atleast 10 minutes to start up which seems a bit too long.

@seanlip
Copy link
Member

seanlip commented May 20, 2024

@sidharth-05 There's one more thing we need to ask you. Why is this bug happening in the first place -- what PR caused it? (See the "Tips for developers" in the issue description.)

Understanding this is important to verify that what you propose is actually the correct fix, and not a hack.

For the question about the dev server, please start a new thread in GitHub Discussions for it, and provide more details so that the dev workflow team can take a look at it. Thanks!

@sidharth-05
Copy link

@seanlip @Akhilesh-max After checking git blame, I believe the issue was caused from PR #18326. This was the most recent PR about an year ago. In this PR the 'Promo-bar config' changed to 'Enable Promo-Bar' and same for the Promo-Bar message. If in fact, this issue was not present while developing the release-coordinator-page.component.html file this must be the reason for the invisible field. But, nothing prompts me to think anything that was changed for the PR, would cause the issue though as none of the CSS code was changed only the names of the labels.

@seanlip
Copy link
Member

seanlip commented May 21, 2024

Ah, good find, thanks -- I took a look at the video on that PR and the field is missing there, so I think you are probably right that this was an issue since the feature was introduced. /cc @lkbhitesh07 for info.

One last thing to check: can you show a video/screenshot of the promo bar after your proposed changes?

@sidharth-05
Copy link

@seanlip Here is the video of the new update.

Recording.11.mp4

Lmk when I should make the PR.

@seanlip
Copy link
Member

seanlip commented May 22, 2024

@sidharth-05 If I'm looking at the video correctly, the input field still doesn't seem visible before you click it?

@sidharth-05
Copy link

@seanlip Sorry I submitted the wrong video. Here is the correct one:

Recording.12.mp4

Changing the visibility was not the only issue it seems, because it would still disappear when you click out of it. So I just added a box on css for this the updates I made to the code are below. Lmk if any changes.

Screenshot 2024-05-21 at 10 28 02 PM

@seanlip
Copy link
Member

seanlip commented May 22, 2024

@sidharth-05 I've assigned you, thanks. Go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Label to indicate an issue is a regression frontend good first issue Work: Low Solution is known and broken into good-first-issue-sized chunks.
Projects
Status: Todo
Development

No branches or pull requests

4 participants