Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Changes not reflected in preview of concept card or preview tab of skill editor page #20285

Open
sagar-subedi opened this issue May 9, 2024 · 1 comment
Labels
bug Label to indicate an issue is a regression

Comments

@sagar-subedi
Copy link
Collaborator

Describe the bug

While editing a skill, the preview card of a concept should reflect the changes made. Also, the preview tab of the skill itself also be reflective of any changes made, before finally publishing a skill. But the the current behavior of the skill editor page seems to be contrary of this.

URL of the page where the issue is observed.

https://www.oppiatestserver.org/skill_editor/jykK99MCGJTz#/

Steps To Reproduce

  • Log into Oppia test server with an account with curriculum admin access

  • Navigate to topic and skills editor page

  • Click on any skill to edit it

  • Make changes to review material section and save it

  • Click on 'Preview Concept Card' button (You don't see the changes reflected)

  • Now navigate to preview tab (There also you don't see the changes reflected)

  • Publish the changes

  • Reload the page

  • Finally, the changes are reflected on the respective components

Expected Behavior

  • After saving the changes made to any component in the skill editor page, those changes should be reflected in the preview sections of the card and the skill preview tab as well

Screenshots/Videos

changes_not_reflected.mp4

What device are you using?

Desktop

Operating System

Linux

What browsers are you seeing the problem on?

Chrome

Browser version

No response

Additional context

No response

Tips for developers

Before addressing the bug, please identify which PR caused the issue (you can follow the steps here). If you identify the PR, comment on the issue with a link to it. If not, mention the commit hash of the oldest commit you saw the bug on (and the month and year it was made in).

Then, please leave a comment with details of the approach that you plan to take to fix the issue (see example).

Note: If this is your first Oppia issue, please make sure to follow our guidelines for choosing an issue and setting things up. You will also need to show a demo of the fix working correctly on your local machine. Thanks!

@sagar-subedi sagar-subedi added triage needed bug Label to indicate an issue is a regression labels May 9, 2024
@sagar-subedi sagar-subedi changed the title [BUG]: Changes not reflected in preview of concept card or preview tab [BUG]: Changes not reflected in preview of concept card or preview tab of skill editor page May 9, 2024
@seanlip
Copy link
Member

seanlip commented May 15, 2024

Just a note -- I tried this in prod (Oppia.org) and got a different result. The result in develop mentioned above should be taken as canonical and we should fix that -- I am only adding this for the record.

  • The preview card in prod has the same problem as the one mentioned here.
  • However, in prod, when clicking on the Preview tab, I do see the updates. Unfortunately, when clicking back to the Editor tab, those updates disappear. Then, when clicking to the Preview tab again, the updates have fully gone. (Clicking between tabs should not change the stored data, so this is definitely not being handled correctly.)

Here is a video demonstration of the above:

prod-repro-for-bug-2024-05-16_01.21.57.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Label to indicate an issue is a regression
Projects
Status: Todo
Development

No branches or pull requests

2 participants