Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: When switching to a RTL language, the image in the community library section does not mirror the LTW image #20284

Closed
annguyentran opened this issue May 8, 2024 · 1 comment
Labels
bug Label to indicate an issue is a regression

Comments

@annguyentran
Copy link

annguyentran commented May 8, 2024

Describe the bug

When switching to a RTL language, the text and layout is supposed to mirror when a LTW language is chosen but when navigating to the community library section, we can see an image did not change when switching to a RTL language.

URL of the page where the issue is observed.

https://www.oppiatestserver.org/community-library

Steps To Reproduce

  1. Navigate to preferences
  2. Change the language to a RTL language (ex. Arabic)
  3. Navigate to the community library

Expected Behavior

The text and layout for a RTL language option is supposed to mirror the LTR language structure.

Screenshots/Videos

image

image

What device are you using?

Desktop

Operating System

Windows
IOS

What browsers are you seeing the problem on?

Windows (Chrome)
IOS (Safari)

Browser version

Chrome Version 124.0.6367.119 (Official Build) (64-bit)
IOS 17.4.1

Additional context

No response

Tips for developers

Before addressing the bug, please identify which PR caused the issue (you can follow the steps here). If you identify the PR, comment on the issue with a link to it. If not, mention the commit hash of the oldest commit you saw the bug on (and the month and year it was made in).

Then, please leave a comment with details of the approach that you plan to take to fix the issue (see example).

Note: If this is your first Oppia issue, please make sure to follow our guidelines for choosing an issue and setting things up. You will also need to show a demo of the fix working correctly on your local machine. Thanks!

@annguyentran annguyentran added bug Label to indicate an issue is a regression triage needed labels May 8, 2024
@seanlip
Copy link
Member

seanlip commented May 12, 2024

Thanks for filing @annguyentran!

While what you say is generally true, there isn't really a semantic difference in whether the image in this case is LTR or RTL, so I think we probably don't need to fix this (i.e. either direction should be OK since there isn't user-visible impact). But feel free to reopen if you disagree, thanks!

@seanlip seanlip closed this as not planned Won't fix, can't repro, duplicate, stale May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Label to indicate an issue is a regression
Projects
None yet
Development

No branches or pull requests

2 participants