Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: The feedback box allows feedback, for the authors, with more than 1000 characters. #20269

Open
cam-pinheiro opened this issue May 6, 2024 · 3 comments
Labels
bug Label to indicate an issue is a regression good first issue

Comments

@cam-pinheiro
Copy link

Describe the bug

When the student leaves feedback with 1010 characters, it is expected not allow feedback more than 1000 characters. But instead the student can leave a feedback and message “thank you for the feedback” is shown

URL of the page where the issue is observed.

https://www.oppiatestserver.org/explore/G8ZgSj1O4rjE?topic_url_fragment=fractions&classroom_url_fragment=math&story_url_fragment=piece-of-cake&node_id=node_1

Steps To Reproduce

Given the student is playing an exploration
When the student leave feedback on the exploration more than 1000 characters
And click on the “submit”
Then it shows a message “Thank you for the feedback!”

Expected Behavior

Then the system should not allow feedback more than 1000 characters.

Screenshots/Videos

feedback_message
message_1654_characters

What device are you using?

Desktop

Operating System

Windows

What browsers are you seeing the problem on?

Chrome

Browser version

124.0.6367.119 (Build oficial) (64 bits)

Additional context

No response

Tips for developers

Before addressing the bug, please identify which PR caused the issue (you can follow the steps here). If you identify the PR, comment on the issue with a link to it. If not, mention the commit hash of the oldest commit you saw the bug on (and the month and year it was made in).

Then, please leave a comment with details of the approach that you plan to take to fix the issue (see example).

Note: If this is your first Oppia issue, please make sure to follow our guidelines for choosing an issue and setting things up. You will also need to show a demo of the fix working correctly on your local machine. Thanks!

@cam-pinheiro cam-pinheiro added bug Label to indicate an issue is a regression triage needed labels May 6, 2024
@seanlip
Copy link
Member

seanlip commented May 12, 2024

From the product side, I don't think there's an issue with allowing longer feedback. Let's update the limit to 2000 characters, but then let's also enforce the limit as well so that the behaviour is what the user expects.

@Rajvardhan222
Copy link

I would like to solve this but i am new to opensource

@Ari1009
Copy link

Ari1009 commented May 24, 2024

Hello @seanlip, I checked the constant.ts file and noticed the mistake there. I made the necessary fix, and it works. I have attached video proof as well.

scrnli_24_05_2024_20-43-48.mp4

In this example, I used a string with 2001 characters, causing the last word mere to appear as mer in the feedback form, excluding the e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Label to indicate an issue is a regression good first issue
Projects
Status: Todo
Development

No branches or pull requests

4 participants