Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS custom audio module used in Network test does not clean up #46

Open
dheerajjain11 opened this issue Nov 28, 2018 · 0 comments
Open

Comments

@dheerajjain11
Copy link

We are running Network test on iOS by first testing with test session id and later running an actual user session with actual session id for event. When running this use case, iOS App crashes. This crash does not happen if we use Android code. We looked at network test code for iOS and here is the issue:

• Network test overrides the microphone’s audio module with a custom audio module object
• After the test, the custom audio module object’s clean-up is attempted
• However, the clean-up seemingly fails, as when a real session tries to use the audio module later, it results in a crash
• We have tested that the crash is avoided when we bypass custom audio module settings in the sample. Here are snippets of code that we commented:

File: OTNetworkTest.m
Function Name: runConnectivityTestWithApiKey
Commented lines (66-72):
if(!_myAudioDevice)
{
_myAudioDevice = [[OTDefaultAudioDevice alloc] init];
}
[OTAudioDeviceManager setAudioDevice:_myAudioDevice];
[_myAudioDevice setAudioPlayoutMute:YES];

Function Name: dispatchResultsToDelegateWithResult
Commented lines (101-102)
[_myAudioDevice setAudioPlayoutMute:NO];
[OTAudioDeviceManager setAudioDevice:nil];
• In this case, the default audio device, picks up the audio, just as in case of a real session. But we get audio bandwidth difference as compared to when we use custom audio module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant