Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed privacy issue #4525

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixed privacy issue #4525

wants to merge 2 commits into from

Conversation

SharanRP
Copy link

closes #4507

@SharanRP
Copy link
Author

My older account, @jadebrain213, inadvertently got configured into my terminal due to some incorrect settings.

@AntonKhorev
Copy link
Contributor

@SharanRP
Copy link
Author

Do I need to write the test case?

@tomhughes
Copy link
Member

I don't think there's much point in a test case for this.

@SharanRP
Copy link
Author

then what should be done, I have made the changes you asked for in the last PR, kindly apologize if I did something wrong again

@tomhughes
Copy link
Member

Just be patient for now.

@tomhughes
Copy link
Member

So I think my main question here is firstly is this needed at all, and if it is then is this the right way to do it.

The geographic location isn't really special - everything on the edit profile page is displayed as part of the public profile so in principle this warning applies to everything there.

You could certainly argue that since we separated these out into a separate page it is obvious from the fact that you're editing the profile by hitting "Edit Profile" on the visible profile that this information will be public.

If a warning is needed then my thought is that it should be at the top of the page and warn that everything on the page will be revealed as part of the public profile.

@AntonKhorev
Copy link
Contributor

The geographic location isn't really special - everything on the edit profile page is displayed as part of the public profile so in principle this warning applies to everything there.

It's more special compared to "Profile Description" or "Image" because it's not obvious how it is used and were it is shown. When you edit the location and go back to your profile page, you can't see the location you entered on this page.

@AntonKhorev
Copy link
Contributor

Another solution is to make the location editable on the dashboard page where it is used. Currently we just link to the profile edit page:

image

@SharanRP
Copy link
Author

@AntonKhorev and @tomhughes I will try the solutions you asked for

@tomhughes
Copy link
Member

I'd suggest waiting until we have some agreement on what we want before you make any more changes.

@SharanRP
Copy link
Author

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Home Location privacy notice
4 participants