Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortcut 2 disaster #9398

Open
jidanni opened this issue Dec 2, 2022 · 2 comments · May be fixed by #10118
Open

Shortcut 2 disaster #9398

jidanni opened this issue Dec 2, 2022 · 2 comments · May be fixed by #10118
Labels
usability An issue with ease-of-use or design

Comments

@jidanni
Copy link
Contributor

jidanni commented Dec 2, 2022 •
edited

I was just reading #9395 (comment)
So decided to give it a try. I was enjoying adding nodes to a way with the spacebar, until I realized that two taps of the space bar in the same spot didn't end the line. (It's "mouse over men": You got to have a real mouse if you want to click in the same spot to end a way, apparently.)
That is bug one.

So then I put in the cursor on the Line button. I learned via the help balloons about the shortcut "2".

So I guessed that maybe "2" is the way to end the line using keyboard shortcuts.

So, okay, I started the line a/k/a way via this 2 shortcut.

And happily added nodes using the space bar.

And, of course sooner or later it is time to end the way, so to end it I just reached for the 2 key on my keyboard and guess what happened...

Kabam! Entire painstakingly entered way blown to smithereens. Eliminated from the face of the earth.

That is bug two.

So now you're saying, "Dry your weeping eyes and simply reach for the undo/redo buttons."

Well the undo/redo buttons deny any hint that any of this ever happened.

That is bug number three.

By the way, it's that "2" that wiped the undo memory, not the space bar to blame.

Digging in the help manual, we learn we're supposed to hit Enter. "My mistake," as Pee Wee Herman might have said.

Well it should also say, "Don't hit 2 again because something bad will happen."
@DujaOSM
Copy link

DujaOSM commented Dec 2, 2022 •
edited

While the above might not be a perfect issue report, I'd like to thank Jidanni for rising the issue (which has also hit myself a couple of times), and try to summarize steps for reproduction:

  1. Begin drawing a line or an area, and draw several points
  2. While still in drawing mode, hit either 1, 2, 3, or Delete on the keyboard

As the result, the entered data is iretrievably gone, and cannot be restored by Undo.

Preferably, neither of the shortcuts (and probably none at all, except Backspace) should have any effect while in line drawing mode. Alternatively, Undo should restore the last drawn state.

@DujaOSM
Copy link

DujaOSM commented Dec 2, 2022

P.S. We do need some shortcuts to work in this mode, such as the ones that (de)activate visibility of various features (B for Backgrounds, U for Map features or G for Green changes).

But should anyone want to tackle this, please also get rid of the goddam L for Locate me (which has usability of -1) (#9128, #8474).

@tyrasd tyrasd added the usability An issue with ease-of-use or design label May 3, 2023
@k-yle k-yle linked a pull request Feb 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
usability An issue with ease-of-use or design
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

prevent certain keyboard shortcuts causing all work to be lost k-yle/iD
3 participants
@jidanni @tyrasd @DujaOSM