Coding style: allow 'unused_' prefix, recomment prototype == definition #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the subject of function parameters, recommended choice is to have the prototype match the function definition, including parameter names. For better clarity when the need arises, unused parameters may be prefixed with 'unused_', but only in the function definition, not the prototype. Fixes openssl#48
|
Note: I'm pondering a proposal that's been made internally, that allows parameter names in the prototype to become comments, like this: int OPENSSL_foo(char * /* bar */, size_t /* barlen */);The benefit is that it avoids clashes when another header that contains something like this is included as well: #define bar (10) |
|
This needs team discussion and vote, right? |
|
I think so. |
openssl-machine
force-pushed
the
master
branch
from
4c6dea4
to
79ff40e
Compare
|
Because the coding style guide has moved and being edited since this, I'm dropping it. This didn't get any traction, so... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the subject of function parameters, recommended choice is to have
the prototype match the function definition, including parameter
names. For better clarity when the need arises, unused parameters may
be prefixed with 'unused_', but only in the function definition, not
the prototype.
Fixes #48