Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default for the stage release script should not be the current user #167

Open
mattcaswell opened this issue Sep 28, 2023 · 2 comments
Open

Comments

@mattcaswell
Copy link
Member

When running stage-release.sh if you neglect to supply the "--local-user" argument then it defaults to the current user. This is almost never the correct answer since it signs the release tarball with the current user's gpg key, rather than the team key.

It probably should default to the team key, or alternatively fail.

@levitte
Copy link
Member

levitte commented Sep 29, 2023

I would default it to the team key. I just found out that the key user id (i.e. any email address associated with it) can be used in place of the hexadecimal id, so it would be a good idea to use that as a default.

@levitte
Copy link
Member

levitte commented Sep 29, 2023

I have a few things lying around that align with this. I'll collect them into a PR on Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants