Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider compat CI is broken because of X25519/X448 having fips=no on master #24246

Open
t8m opened this issue Apr 23, 2024 · 2 comments · May be fixed by #24348, #24354, #24349 or #24347
Open

Provider compat CI is broken because of X25519/X448 having fips=no on master #24246

t8m opened this issue Apr 23, 2024 · 2 comments · May be fixed by #24348, #24354, #24349 or #24347
Assignees
Labels
branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 triaged: bug The issue/pr is/fixes a bug
Milestone

Comments

@t8m
Copy link
Member

t8m commented Apr 23, 2024

The two broken jobs here: https://github.com/openssl/openssl/actions/runs/8802704031/job/24159479487 and https://github.com/openssl/openssl/actions/runs/8802704031/job/24159478903 are failing because they run libcrypto/libssl tests from 3.1 and 3.0 branches against the master branch version of the fips provider.

Of course that does not work well because on these branches there are testcases that expect the X25519 and X448 having fips=yes property and being advertised by the fips provider among the groups capability.

Furthermore in the provider compat CI we do not run any tests against the 3.2 an 3.3 branches, which would have the same problem.

@t8m t8m added branch: master Merge to master branch triaged: bug The issue/pr is/fixes a bug branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 labels Apr 23, 2024
@nhorman
Copy link
Contributor

nhorman commented Apr 29, 2024

need to make the tests conditional on fips=yes

@nhorman nhorman added this to the 3.4.0 milestone Apr 29, 2024
@paulidale
Copy link
Contributor

The compatibility test needs to have additional versions added manually (in two places) and this will multiply quadratically with time based releases. Something for WG to discuss limiting somehow. This updating should be added to the release checklist since it has been missed twice in a row.

Any fix has to work for older branches and releases. I.e. code changes are difficult anywhere except master and impossible for the FIPS providers.

The evp_test tests include a FIPS version field to allow them to be conditional and we've backported changes to this in the past & this is the solution for such failures. Other test failures are more difficult. We've made failure to fetch be not an error in places I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 triaged: bug The issue/pr is/fixes a bug
Projects
Status: In progress
3 participants