Incompatibility of maps made before Soldat 1.7

[insellium]

Map: KirbyDreamland
Scenery shifts, so you have to fix the map manually through PolyWorks.

1.6.9

OpenSoldat or 1.7.1.1

[BranDougherty]

Prior to Soldat 1.7, the game ignored the Prop.Width/Prop.Height fields in the PMS format, and assumed that 1 pixel equaled 1 game distance unit. When the work for HD was done in 1.7, they needed to decouple pixels and game distances. Their choice was to use the previously ignored prop width and height fields.

For most maps this should work fine. PolyWorks has written the width/height of the texture to those fields since at least 2009, preferring to use the Prop.ScaleX/Prop.ScaleY fields to change the size of props. This works in all versions of Soldat, so a lot of maps should be unaffected. But likely some maps made with very old versions of PolyWorks, or even Soldat Map Maker can have incorrect data in those fields. Even maps with corrupted data in those fields would still work with old versions. But because Soldat 1.7 and OpenSoldat are reading those fields, the incorrect data is read as the width/height of the prop, and you see the ugly results there (specifically with !Kirby1.bmp).

There's no version indicator to differentiate between files made for Soldat < 1.7, so we would have to go off heuristics like the PMS Date fields, file last modified entries, and TMS upload date.

At the very least it should be possible to add a Fix Soldat <= 1.6.9 Map button to PolyWonks to update the Prop.Width/Prop.Height fields in props. Non-default props should have it set to the width/height of their texture, and default sceneries should have it set to width/height of the Soldat 1.6.9 default texture.