Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visible backticks in OCP 4.13 release notes #64740

Closed
ShaunaDiaz opened this issue Sep 14, 2023 · 11 comments
Closed

Visible backticks in OCP 4.13 release notes #64740

ShaunaDiaz opened this issue Sep 14, 2023 · 11 comments
Assignees

Comments

@ShaunaDiaz
Copy link
Contributor

Which section(s) is the issue in?

https://docs.openshift.com/container-platform/4.13/release_notes/ocp-4-13-release-notes.html#ocp-4-13-bug-fixes
This bullet is just above https://docs.openshift.com/container-platform/4.13/release_notes/ocp-4-13-release-notes.html#ocp-4-13-technology-preview, so it is likely easier to go there and scroll up.

What needs fixing?

Fix the backticks by inserting a space between "Windows" and the first backtick of "DaemonSet."

  • Previously, the Windows Machine Config Operator (WMCO) could not drain DaemonSet workloads. This issue caused WindowsDaemonSet pods to block Windows nodes that the WMCO attempted to remove or upgrade. With this update, an WMCO includes additional role-based access control (RBAC) permissions, so that the WMCO can remove DaemonSet workloads. An WMCO can also delete any processes that were created with the containerd shim, so that DaemonSet containers do not exist on a Windows instance after a WMCO removes a node from a cluster. (OCPBUGS-5354)
@ShaunaDiaz ShaunaDiaz changed the title Visible backticks in 4.13 release notes Visible backticks in OCP 4.13 release notes Sep 14, 2023
@bergerhoffer
Copy link
Contributor

bergerhoffer commented Sep 14, 2023

Marking this as a good candidate for Hacktoberfest

The PR should be submitted against the enterprise-4.13 branch

@7h3-3mp7y-m4n
Copy link

can I take this issue ?

@ShaunaDiaz
Copy link
Contributor Author

Hey there @7h3-3mp7y-m4n! 🎉 Absolutely!
Just a quick reminder: if you'd like this contribution to be a part of your Hacktoberfest achievements, it's best to submit your pull request for this issue on or after October 1st.
Also, please be sure to read the Participation Guidelines which include:

  • Timeframe Alert: Make sure you create your PRs between October 1 and October 31. And no worries about time zones, any from UTC-12 through UTC+14 works.
  • Visibility Check: Your PRs should be made to public repositories that aren't archived.
    Happy coding, and here's to a fantastic Hacktoberfest! 🚀🍂

@ayan-joshi
Copy link

Any new issues @ShaunaDiaz to contribute in ?

@ShaunaDiaz
Copy link
Contributor Author

@ayan-joshi My colleague still has three unassigned issues if you'd like to take a look:
#55184
#54441
#53958

@rolfedh
Copy link
Contributor

rolfedh commented Oct 31, 2023

Hi @7h3-3mp7y-m4n, are you still interested fixing this issue?

@7h3-3mp7y-m4n
Copy link

Yes I'm interested in it , I'll soon raise a PR

@ShaunaDiaz
Copy link
Contributor Author

Hi @7h3-3mp7y-m4n, are you able to raise a PR for this issue?

@7h3-3mp7y-m4n
Copy link

sorry for the delay @ShaunaDiaz but I did it.

@ShaunaDiaz
Copy link
Contributor Author

ShaunaDiaz commented Nov 7, 2023

Thank you @7h3-3mp7y-m4n, PR looks good! #67516

@ShaunaDiaz
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants