Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support to inject telemetry instances to plugins #13636

Merged
merged 3 commits into from
May 17, 2024
Merged

Adds support to inject telemetry instances to plugins #13636

merged 3 commits into from
May 17, 2024

Conversation

Gaganjuneja
Copy link
Contributor

@Gaganjuneja Gaganjuneja commented May 13, 2024 •
edited

Description

This change will make available the telemetry instances such as tracer and metrics registry to all the plugins.

Related Issues

Resolves #13635

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Other Telemetry:Metrics PRs or issues specific to telemetry metrics framework Telemetry:Tracing PRs or issues specific to telemetry tracing framework labels May 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for d30fca6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for b18e370: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 2ee4bc5: SUCCESS

@codecov Codecov
Copy link

codecov bot commented May 13, 2024 •
edited

Codecov Report

Attention: Patch coverage is 83.78378% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 71.57%. Comparing base (b15cb0c) to head (2ee4bc5).
Report is 289 commits behind head on main.

❗ Current head 2ee4bc5 differs from pull request most recent head f58cd00

Please upload reports for the commit f58cd00 to get more accurate results.

Files Patch % Lines
...opensearch/telemetry/service/TelemetryService.java 72.72% 3 Missing and 3 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #13636      +/-   ##
============================================
+ Coverage     71.42%   71.57%   +0.14%     
- Complexity    59978    61124    +1146     
============================================
  Files          4985     5053      +68     
  Lines        282275   287158    +4883     
  Branches      40946    41607     +661     
============================================
+ Hits         201603   205520    +3917     
- Misses        63999    64647     +648     
- Partials      16673    16991     +318

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 7a71dcd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for a32b4c9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 46a2319: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta reta added the backport 2.x Backport to 2.x branch label May 17, 2024
@reta
Copy link
Collaborator

reta commented May 17, 2024

❌ Gradle check result for 46a2319: FAILURE

@Gaganjuneja please rebase against main, thank you

Gagan Juneja added 3 commits May 17, 2024 19:08
Adds support to inject telemetry instances to plugins
73def4d 
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Adds test
2bc2417 
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
incorporate pr comments
f58cd00 
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
@github-actions github-actions bot added v2.15.0 Issues and PRs related to version 2.15.0 v3.0.0 Issues and PRs related to version 3.0.0 labels May 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for f58cd00: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented May 17, 2024

❌ Gradle check result for f58cd00: FAILURE

#13476
#10006
#13600

@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for f58cd00: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@reta reta merged commit 6ba6f59 into opensearch-project:main May 17, 2024
33 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 17, 2024
@github-actions
Adds support to inject telemetry instances to plugins (#13636)
e1d1910 
* Adds support to inject telemetry instances to plugins

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Adds test

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* incorporate pr comments

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
(cherry picked from commit 6ba6f59)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request May 17, 2024
Merged
reta pushed a commit that referenced this pull request May 17, 2024
@opensearch-trigger-bot @github-actions
Adds support to inject telemetry instances to plugins (#13636) (#13736)
cf20a61 
* Adds support to inject telemetry instances to plugins



* Adds test



* incorporate pr comments



---------



(cherry picked from commit 6ba6f59)

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request May 17, 2024
@Gaganjuneja @deshsidd
Adds support to inject telemetry instances to plugins (opensearch-pro…
84a7eae 
…ject#13636)

* Adds support to inject telemetry instances to plugins

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Adds test

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* incorporate pr comments

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta approved these changes

@andrross andrross andrross approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89 dreamer-89 is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng tlfeng is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request Other Telemetry:Metrics PRs or issues specific to telemetry metrics framework Telemetry:Tracing PRs or issues specific to telemetry tracing framework v2.15.0 Issues and PRs related to version 2.15.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] [Telemetry] Make available the instance of tracer and metrics registry to all the plugins
3 participants
@Gaganjuneja @reta @andrross