Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Implements indexSettings similarity. #987

Open
ritty27 opened this issue May 12, 2024 · 3 comments
Open

[Feature Request] Implements indexSettings similarity. #987

ritty27 opened this issue May 12, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@ritty27
Copy link

ritty27 commented May 12, 2024

Is your feature request related to a problem? Please describe

Currently, there is no similarity setting in indexSettings when creating new index through CreateIndexRequest in opensearch.
The Elasitcsearch java-client also has this feature, but the openSearch java-client does not provide this feature.

"similarity": {
  "custom_similarity": {
    "type": "BM25",
    "k1": 1.2,
    "b": 0.75,
    "discount_overlaps": "true"
  }
}

Describe the solution you'd like

Add a similarity setting when an index is created using java-client.

Related component

Indexing

Describe alternatives you've considered

Implement similar to the code implemented in elasticsearch.

Additional context

No response
@ritty27 ritty27 added enhancement New feature or request untriaged labels May 12, 2024
@ritty27 ritty27 mentioned this issue May 12, 2024
Closed
9 tasks
@owaiskazi19
Copy link
Member

owaiskazi19 commented May 14, 2024 •
edited

@ritty27 thanks for creating the issue. The right place for this issue would be in https://github.com/opensearch-project/opensearch-java. @opensearch-project/admin can you transfer this issue? Thanks

@gaiksaya gaiksaya transferred this issue from opensearch-project/OpenSearch May 14, 2024
@ritty27
Copy link
Author

ritty27 commented May 15, 2024

@owaiskazi19
I created a PR for the issue on https://github.com/opensearch-project/OpenSearch, should I also move the PR?
PR Link : opensearch-project/OpenSearch#13631

@owaiskazi19
Copy link
Member

@owaiskazi19 I created a PR for the issue on https://github.com/opensearch-project/OpenSearch, should I also move the PR? PR Link : opensearch-project/OpenSearch#13631

Yes, you can close out the PR and open a new one in opensearch-java.

@ritty27 ritty27 mentioned this issue May 16, 2024
Open
@dblock dblock removed the untriaged label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add similarity settings when using CreateIndexRequest ritty27/OpenSearch
3 participants
@dblock @owaiskazi19 @ritty27