Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sadly, we can't add .scad files to the issues in the openSCAD repository #5090

Open
JamesC1 opened this issue Apr 14, 2024 · 9 comments
Open

Comments

@JamesC1
Copy link

JamesC1 commented Apr 14, 2024

Github has a facility to add files to an issue. If it's an issue with code in openSCAD, then the files that we want to add may well be .scad files.

Environment
Github allows a limited set of file suffixes, including .txt, which it probably takes as implying particular semantics.

Issue
.scad, the natural name for our code files, is not on the list. I've made a soft-link, in order to rename a file to upload it, in another ticket.

@t-paul
Copy link
Member

t-paul commented Apr 14, 2024

Can you please elaborate on what you expect the OpenSCAD team to do here? We have no control over how github works, so I don't see any possible action on our side.

@t-paul t-paul closed this as completed Apr 14, 2024
@t-paul t-paul reopened this Apr 14, 2024
@UBaer21
Copy link
Contributor

UBaer21 commented Apr 14, 2024

@JamesC1
Copy link
Author

JamesC1 commented Apr 14, 2024 via email

@UBaer21
Copy link
Contributor

UBaer21 commented Apr 14, 2024

James - you clicked on a text file containing the scad code. This is what happens if you upload a file and others click on that file - it will be downloaded.

You always can paste the scad code itself into the comment and format as code.

@jordanbrown0
Copy link
Contributor

You always can paste the scad code itself into the comment and format as code.

And that's usually the better answer anyway, because then people can directly read it. If it seems too large to put into a comment, then it probably is too large to be a reasonable demonstration of a problem.

@JamesC1
Copy link
Author

JamesC1 commented Apr 16, 2024 via email

@UBaer21
Copy link
Contributor

UBaer21 commented Apr 16, 2024

When people past their library and build info - this already exceeds 300 lines.
So yes, you can paste 150 lines. More important is that no external lib/files/fonts etc. are needed.
If you can't avoid this it can make sense to package everything into a zip container and upload - but normally a minimal case can be constructed with some effort.

@pca006132
Copy link
Member

You can put it inside <details> ... </details>

@nomike
Copy link

nomike commented May 4, 2024

For whatever strange reason, GitHub imposes a limit on the file extensions a file you upload could happen, but on the other side they allow .gz file, meaning you can upload whatever you want by just compressing it with gzip first.

This renders the whole "You are only allowed to upload the following types of files" restriction useless.

But it's to our benefit in this case.

So, just gzip the file and everything works and you don't have to mess around with weird incorrect file extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants