Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "conceptMappings" from dummy form schema #130

Open
mogoodrich opened this issue May 23, 2023 · 5 comments
Open

Remove "conceptMappings" from dummy form schema #130

mogoodrich opened this issue May 23, 2023 · 5 comments

Comments

@mogoodrich
Copy link
Member

mogoodrich commented May 23, 2023

The dummy schema from provided by the form builder includes "conceptMapping" fields, ie:

"questions": [
            {
              "label": "Another Question of type obs whose answers get rendered as radio inputs",
              "type": "obs",
              "questionOptions": {
                "rendering": "radio",
                "concept": "system-defined-concept-uuid",
                "answers": [
                  {
                    "concept": "another-system-defined-concept-uuid",
                    "label": "Choice 1",
                    "conceptMappings": []
                  },
                  {
                    "concept": "yet-another-system-defined-concept-uuid",
                    "label": "Choice 2",
                    "conceptMappings": []
                  },
                  {
                    "concept": "yet-one-more-system-defined-concept-uuid",
                    "label": "Choice 3",
                    "conceptMappings": []
                  }
                ]
              },
              "id": "anotherSampleQuestion"
            }

These "conceptMappings" fields are currently ignored (and probably always will be) so we should remove them from the dummy schema to avoid confusion.

fyi @denniskigen @samuelmale

@samuelmale
Copy link
Member

@mogoodrich Assuming support for "concept mappings" is a priority for orgs like PIH for an MVP, I'm inclined to keep them considering that we may introduce this support very soon.

@mogoodrich
Copy link
Member Author

mogoodrich commented May 24, 2023

@samuelmale for concept mapping support, we'd want to be able to unqiuely reference a concept by mapping and source instead of uuid, so I think we'd want to use the concept field for this, ie support:

answers": [
                  {
                    "concept": "CIEL:1234",
                    "label": "Choice 1"
                  },

We could consider using a mapping field instead of a concept field, like:

answers": [
                  {
                    "conceptMapping": "CIEL:1234",
                    "label": "Choice 1"
                  }

But I don't see a case where we'd want to ever specify multiple mappings or use an array.

@samuelmale
Copy link
Member

Makes perfect sense @mogoodrich!

@hadijahkyampeire
Copy link
Contributor

@samuelmale are you tracking this issue and working on it?

@samuelmale
Copy link
Member

No @hadijahkyampeire, I'm not. Feel free to take it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants