Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Contributing] Mentions string.format, are f-strings allowed? #1295

Open
eddiebergman opened this issue Jan 7, 2024 · 1 comment
Open

[Contributing] Mentions string.format, are f-strings allowed? #1295

eddiebergman opened this issue Jan 7, 2024 · 1 comment

Comments

@eddiebergman
Copy link
Collaborator

Hiyo,

Just reading the contributing guide and in the sections it mentions about the pep8 guidelines, it doesn't mention f-strings. I would imagine these are allowed and we should add a section to CONTRIBUTING.md?

@PGijsbers
Copy link
Collaborator

F-strings are the preferred way to format strings since a few years, but we didn't go an change old-style formatting unless a PR affected them. Might be useful to just run something like flynt (no experience using it) to convert all strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants