Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow different currencies for the price #19

Open
RafiKueng opened this issue Jan 25, 2016 · 2 comments
Open

Allow different currencies for the price #19

RafiKueng opened this issue Jan 25, 2016 · 2 comments

Comments

@RafiKueng
Copy link

not only €.. CHF / SFr would be nice as well, for example for Swiss universities..

@mswart
Copy link
Member

mswart commented Jan 28, 2016

Would it be enough to be able to switch the concurrency completely? Either or CHF / SFr and not both at a time?

@RafiKueng
Copy link
Author

I was more suggesting it to be considered for a future upgrade of the protocol.. on the long term..
It could also be that meals have prices in two currencies (here Swiss Francs and Euro)
maybe something like:

<price role="student" currency="EUR">2.00</price>
<price role="student" currency="CHF">2.00</price>
<price role="employee" currency="CHF">2.00</price>

I suggest using ISO 4217 abbr. and not the currency symbol, that should be rather a setting in the client app.
You can make it default to EUR, so it will be perfectly backwards compatible.

On short term, I don't really care what symbol is behind the price, when I write the scrapper.. But it could be confusing for others.

alternatives I all like less

<price role="student">2.00 EUR</price>
<price role="student">2.00 CHF</price>

<price role="student">
  <currency>
    <type>EUR</type>
    <amount>2.00</amount>
  </currency>
  <currency>
    <type>CHF</type>
    <amount>2.00</amount>
  </currency>
</price>

but I havent thought about it much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants