Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated the images and markdown showing wrong file names of COBOL compilation output #302

Closed
wants to merge 1 commit into from
Closed

updated the images and markdown showing wrong file names of COBOL compilation output #302

wants to merge 1 commit into from

Conversation

ashiskumarnaik
Copy link
Contributor

Proposed changes

updated the images and markdown showing wrong file names of COBOL compilation output

Fixes # (#301 )

Type of change

What type of changes does your PR introduce to the COBOL Programming Course? Put an x in the boxes that apply.

  • Bug fix (change which fixes one or more issues)
  • New feature (change which adds functionality or features to the course)
  • Translations (change which adds or modifies translations of the course)
  • Documentation (change which modifies documentation related to the course)
  • This change requires an update to the course's z/OS environment

Checklist:

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the Contributing Guideline
  • I have included a title and description for this PR
  • I have DCO-signed all of my commits that are included in this PR
  • I have tested it manually and there are no regressions found
  • I have commented my code, particularly in hard-to-understand areas (if appropriate)
  • I have made corresponding changes to the documentation (if appropriate)

@ashiskumarnaik
updated the images and markdown showing wrong file names of COBOL com…
3a987f4 
…pilation output

Signed-off-by: Ashis Kumar Naik <ashishami2002@gmail.com>
tanto259
tanto259 requested changes May 28, 2023
View reviewed changes
Copy link
Member

@tanto259 tanto259 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, Ashis! I did not realize that they change the layout of the Jobs view on Zowe Explorer again...

Left some comments on 2 of the images.

COBOL Programming Course #2 - Learning COBOL/Images/image104.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove all reference of your Z9XXXX ID from the image? We don't want people to start trying out your ID on the system and make the system blocks your ID :)

COBOL Programming Course #2 - Learning COBOL/Images/image106.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here with the ID

@tanto259 tanto259 added the bug Something isn't working label May 30, 2023
@tanto259 tanto259 linked an issue May 30, 2023 that may be closed by this pull request
COBOL compilation output file names are wrongly displayed. #301
Open
@ashiskumarnaik
Copy link
Contributor Author

Hi @tanto259 If I take screenshots , then my user id will also be captured . Do I need to blur it out ? (any suggestion)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanto259 tanto259 Awaiting requested review from tanto259

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

COBOL compilation output file names are wrongly displayed.
2 participants
@ashiskumarnaik @tanto259