Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing WebGL renderer tests #15735

Open
ahocevar opened this issue Apr 13, 2024 · 1 comment
Open

Failing WebGL renderer tests #15735

ahocevar opened this issue Apr 13, 2024 · 1 comment
Labels

Comments

@ahocevar
Copy link
Member

ahocevar commented Apr 13, 2024

Several WebGL renderer tests are failing for me locally:

Chrome Headless 123.0.0.0 (Mac OS 10.15.7) ol.webgl.styleparser parseLiteralStyle icon style contains main properties and expressions, icon specified as data url sets up builder accordingly FAILED
	Error: expected [ 'vec2 u_texture980902294_size',
	  'sampler2D u_texture980902294' ] to sort of equal [ 'sampler2D u_texture980902294' ]
	    at Assertion.assert (/Users/ahocevar/projects/openlayers/node_modules/expect.js/index.js:96:13)
	    at Assertion.eql (/Users/ahocevar/projects/openlayers/node_modules/expect.js/index.js:230:10)
	    at Context.<anonymous> (/var/folders/8j/lpm7ppqs7zl9w1lmwgw4kxj00000gn/T/_karma_webpack_91171/webpack:/ol/test/browser/spec/ol/webgl/styleparser.test.js:330:1)
.......................
Chrome Headless 123.0.0.0 (Mac OS 10.15.7) ol.webgl.styleparser parseLiteralStyle stroke style stroke pattern, tint, spacing, offset and size sets the color expression FAILED
	Error: expected 'vec4(1.0, 0.0, 0.0, 1.0) * sampleStrokePattern(u_texture980902294, u_texture980902294_size, vec2(0., u_texture980902294_size.y) + vec2(5.0, 5.0) * vec2(0., -1.) + vec2(5.0, 10.0) * vec2(1., -1.), vec2(5.0, 5.0), (2.0 * 10.0), currentLengthPx, currentRadiusRatio, v_width)' to sort of equal 'vec4(1.0, 0.0, 0.0, 1.0) * sampleStrokePattern(u_texture980902294, vec2(1.0, 1.0), vec2(0., vec2(1.0, 1.0).y) + vec2(5.0, 5.0) * vec2(0., -1.) + vec2(5.0, 10.0) * vec2(1., -1.), vec2(5.0, 5.0), (2.0 * 10.0), currentLengthPx, currentRadiusRatio, v_width)'
	    at Assertion.assert (/Users/ahocevar/projects/openlayers/node_modules/expect.js/index.js:96:13)
	    at Assertion.eql (/Users/ahocevar/projects/openlayers/node_modules/expect.js/index.js:230:10)
	    at Context.<anonymous> (/var/folders/8j/lpm7ppqs7zl9w1lmwgw4kxj00000gn/T/_karma_webpack_91171/webpack:/ol/test/browser/spec/ol/webgl/styleparser.test.js:766:1)
....
Chrome Headless 123.0.0.0 (Mac OS 10.15.7) ol.webgl.styleparser parseLiteralStyle fill style fill pattern, tint, offset and size sets the color expression FAILED
	Error: expected 'vec4(1.0, 0.0, 0.0, 1.0) * sampleFillPattern(u_texture980902294, u_texture980902294_size, vec2(0., u_texture980902294_size.y) + vec2(5.0, 5.0) * vec2(0., -1.) + vec2(5.0, 10.0) * vec2(1., -1.), vec2(5.0, 5.0), pxOrigin, pxPos)' to sort of equal 'vec4(1.0, 0.0, 0.0, 1.0) * sampleFillPattern(u_texture980902294, vec2(1.0, 1.0), vec2(0., vec2(1.0, 1.0).y) + vec2(5.0, 5.0) * vec2(0., -1.) + vec2(5.0, 10.0) * vec2(1., -1.), vec2(5.0, 5.0), pxOrigin, pxPos)'
	    at Assertion.assert (/Users/ahocevar/projects/openlayers/node_modules/expect.js/index.js:96:13)
	    at Assertion.eql (/Users/ahocevar/projects/openlayers/node_modules/expect.js/index.js:230:10)
	    at Context.<anonymous> (/var/folders/8j/lpm7ppqs7zl9w1lmwgw4kxj00000gn/T/_karma_webpack_91171/webpack:/ol/test/browser/spec/ol/webgl/styleparser.test.js:873:1)

@jahow, can you please take a look at this? Let me know if you need more information. One thing that might be of inerest: my device has a pixel ratio of 2.

@ahocevar ahocevar added the bug label Apr 13, 2024
@jahow
Copy link
Contributor

jahow commented Apr 14, 2024

Thanks for the pointer, I'll have a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants