Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WFS property format writer handling of string values with new lines #10127

Open
aboulan opened this issue Oct 14, 2019 · 3 comments · May be fixed by #15638
Open

WFS property format writer handling of string values with new lines #10127

aboulan opened this issue Oct 14, 2019 · 3 comments · May be fixed by #15638

Comments

@aboulan
Copy link

aboulan commented Oct 14, 2019

Hello,
When updating a feature through WFS, if there are any newline characters in string properties, these are lost (for example, geoserver handles these newlines as whitespace)

Instead I think the WFS format writer should protect string properties in CDATA block when there are any newline characters in string values (or maybe for any string value?)
The attached patch solves the issue for me:

openlayers-fix-WFS-write-property.patch.txt
@stale
Copy link

stale bot commented Dec 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 13, 2019
@stale stale bot closed this as completed Dec 20, 2019
@ahocevar ahocevar reopened this Feb 27, 2024
@stale stale bot removed the stale label Feb 27, 2024
@ahocevar
Copy link
Member

The patch above looks like a good fix. Does anyone want to create a pull request with that fix?

@aboulan
Copy link
Author

aboulan commented Mar 13, 2024

Hello,
Thank you for reactivating this issue. I have created a PR with the fix. I hope this is the correct way to do it since it is my first PR on this project.

@ahocevar ahocevar linked a pull request Mar 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix WFS property format writer for multiline strings aboulan/openlayers
2 participants
@ahocevar @aboulan