Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon cache for RegularShapes #15147

Open
MoonE opened this issue Sep 17, 2023 · 1 comment · May be fixed by #15169
Open

Icon cache for RegularShapes #15147

MoonE opened this issue Sep 17, 2023 · 1 comment · May be fixed by #15169
Labels
feature request pull request accepted

Comments

@MoonE
Copy link
Contributor

MoonE commented Sep 17, 2023

With the new style expressions, should there be some kind of IconCache for RegularShapes?

An example like https://openlayers.org/en/latest/examples/regularshape.html that is implemented with style expressions will re-render the RegularShape canvas for every drawn feature.

Even if the RegularShape is only re-rendered when the resulting style actually changed that will not help much when the features are in a random order.
@ahocevar
Copy link
Member

I'm wondering if it wouldn't be sufficient to change the default icon cache size from 32 to a higher number, and use it for all Image styles, not just icons. I imagine this would be quite a small change.

@MoonE MoonE linked a pull request Sep 24, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request pull request accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

RegularShape cache MoonE/openlayers
2 participants
@ahocevar @MoonE