-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: pivmet: an R
package proposing pivotal methods for consensus clustering and mixture modelling
#6461
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: 🔴 Failed to discover a valid open source license |
|
Review checklist for @adriancorrendoConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@LeoEgidi – this may have been discussed already but what license is this software released under? JOSS requires software published here to have a file named |
Hi @arfon , the License, as documented by the description file, is GPL-2 |
I investigate a bit more |
Ok, now I put a LICENSE file at the repository root as suggested
|
Hi @LeoEgidi . I've just created an issue on your repo with my review comments at LeoEgidi/pivmet#1 (comment) Could you please take a look? Thanks, |
Hi @adriancorrendo , thanks a lot for your comments, I took a first look. I'll try to get a deeper look this week, or at most next week. Should I reply your points here or directly in the repo? What do you prefer? Thanks a lot |
Hi Leo, how are you? Hope it helps! |
Review checklist for @larryshamalamaConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @LeoEgidi, thanks for the submission. Overall, looks good, but I do have some doubts with the paper. Some comments below align with @adriancorrendo's review. Major comments/questions
Minor comments
|
I replied the comments from Adrian in the issue he created. Now time to work on the @larryshamalama comments |
Thanks. In line with the comments from @adriancorrendo , we added a new paragraph at the end the "Statement of need" section to make an overview of other R packages related to pivmet. For this reason, we summarized why pivmet is so beneficial in the search of the pivotal units and how this package is naturally related to other existing packages, such as 'rstan', 'rjags' and 'bayesmix'.
Ok, If I well understood your point, in line with one of the comments from @adriancorrendo , we included now in the two examples in the paper, #Example 1 and #Example 2, some relevant lines of R code, basically the same included in the README file.
Thanks, done. We added a new .md file "CODE OF CONDUCT" in the main repo to properly suggest the users how to contribute and report bugs.
Thanks, I read another time, and so far no other typos have been found. I merged the pull request. |
@arfon @larryshamalama @adriancorrendo Thanks a lot;) |
👋 - @skanwal will you check in on this submission? It looks like the author and reviewers are making good progress. Thanks! |
Thanks so much @adriancorrendo and @larryshamalama. Also, thanks @LeoEgidi for staying on top of comments and updates. |
Yes looks good to me! |
I just asked authors to add a R-CMD badge in the README that helps users to see upfront if the package is passing automated tests, ideally also a coverage test like codecov. However, this could be more a "suggestion" than a required revision for acceptance. So, I'm happy with the answers and revisions from the authors. |
Thanks a lot!! I also added the R-CMD suggestion from @adriancorrendo in the readme |
Post-Review Checklist for Editor and AuthorsAdditional Author Tasks After Review is Complete
Editor Tasks Prior to Acceptance
|
@editorialbot generate pdf |
@editorialbot generate pdf |
@editorialbot generate pdf |
Hello @LeoEgidi - how are you going with final proof reading and creating the DOI? |
@editorialbot generate pdf |
Here we are @skanwal |
just posted my final replies here above. Hopefully we are there! Best, and thanks for everything |
@editorialbot generate pdf |
@editorialbot generate pdf |
(ok, super last edits to the r reproducible code. done) |
@editorialbot set 10.5281/zenodo.11243277 as archive |
That doesn't look like a valid DOI value |
@LeoEgidi - did you use similar instructions as this to create DOI? |
@editorialbot set v0.6.0 as version |
Done! version is now v0.6.0 |
yes! |
Submitting author: @LeoEgidi (LEONARDO EGIDI)
Repository: https://github.com/LeoEgidi/pivmet
Branch with paper.md (empty if default branch): master
Version: v0.6.0
Editor: @skanwal
Reviewers: @adriancorrendo, @larryshamalama
Archive: Pending
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@adriancorrendo & @larryshamalama, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @skanwal know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @adriancorrendo
📝 Checklist for @larryshamalama
The text was updated successfully, but these errors were encountered: