-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: GrainLearning: A Bayesian uncertainty quantification toolbox for discrete and continuum numerical models of granular materials #6338
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
Review checklist for @gchureConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @georgiastuartConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @diehlpk, I had some paper revisions come in this week that sucked up my free time. It will be at least another week or so until I get to this. Sorry to the authors for the delay! |
Beginning my review, sorry for the delay!! |
Hi @gchure how is your review going? |
Hi @diehlpk, I caught the flu for the past 5 days and am just coming back to life. I'll be at a conference next week and should have time in the evenings to finish it up. I'll shoot for March 8, if that is okay. |
Thanks for the update and hope you will recover soon. |
Hi @diehlpk, I've finished my review. I've found the software to be in very good shape, with no substantive comments on the structure or functionality. Installation works as advertised, though it seems that building the wheel for Windows is currently failing. I don't have access to a windows machine to test installation, however, so maybe this is not an issue (@luisaforozco can maybe comment on this). My only blocking issue is the status of the software paper (see GrainLearning-#72). I think it could use some more work to better represent the capability of the software. As the authors have very nice documentation, I don't think this should take too much effort. Once they've addressed this point, I can mark my review as complete. Thanks for the patience -- the flu followed by APS march meeting isn't a combo I would recommend, especially if you have reviews to get to! |
Thanks a lot for your review @diehlpk. Regarding the building problem for windows the issue is with a dependency of tensorflow: |
@luisaforozco Please mention that in the documentation and I think it should be fine with the Windows installation issue. Can you add your proposed fix to the testing system? |
Hi @georgiastuart how is your review going? |
Hi @diehlpk, I can mark my review as finished. @luisaforozco addressed all of my comments in terms of the software paper in the corresponding issue. |
@Haipeng-ustc you need to generate the list here. |
@editorialbot generate my checklist |
@Haipeng-ustc I can't do that because you are not a reviewer |
@Haipeng-ustc please try again. |
Hi @georgiastuart how is your review going? |
@editorialbot generate pdf |
@editorialbot recommend-accept |
|
|
👋 @openjournals/bcm-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5277, then you can now move forward with accepting the submission by compiling again with the command |
@luisaforozco as AEiC for JOSS I will now help to process this submission for acceptance in JOSS. I have checked this review, your repository, the archive link, and the paper. Most seems in order, however the below are some points that require your attention:
|
@Kevin-Mattheus-Moerman thanks for the comments! I've made the requested changes to the text.
|
@editorialbot generate pdf |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@luisaforozco congratulations on this JOSS publication!!! Thanks for editing @diehlpk !! And a special thank you to the reviewers: @gchure, @Haipeng-ustc !!! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Dear @Kevin-Mattheus-Moerman, a co-author noticed that there was an error in the acknowledgements: I've updated the |
@editorialbot generate pdf |
@openjournals/dev not sure what to make of this error? Could you advise and perhaps process the re-accept? Thanks! |
@luisaforozco we should be able to reaccept (and fix that acknowledgement) once the paper compilation is working. As this one is accepted it is not on our radar as clearly as the "in process" papers, so do ping me if this doesn't get resolved shortly. |
The draft generation fails because the paper has already been accepted. You can run the reaccept command directly. |
@editorialbot reaccept |
|
🌈 Paper updated! New PDF and metadata files 👉 openjournals/joss-papers#5331 |
Submitting author: @luisaforozco (Luisa Fernanda Orozco)
Repository: https://github.com/GrainLearning/grainLearning
Branch with paper.md (empty if default branch): joss_submission
Version: v2.0.3
Editor: @diehlpk
Reviewers: @gchure, @Haipeng-ustc
Archive: 10.5281/zenodo.11001174
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@gchure & @georgiastuart, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @diehlpk know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @gchure
📝 Checklist for @georgiastuart
📝 Checklist for @Haipeng-ustc
The text was updated successfully, but these errors were encountered: