Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "custom implementations" of OAuth flows #1412

Open
weberjm opened this issue Apr 13, 2022 · 1 comment
Open

Support "custom implementations" of OAuth flows #1412

weberjm opened this issue Apr 13, 2022 · 1 comment

Comments

@weberjm
Copy link
Member

weberjm commented Apr 13, 2022

From @winklerj: while looking at Amazon's OAuth2 authentication https://github.com/amzn/selling-partner-api-docs/blob/main/guides/en-US/developer-guide/SellingPartnerApiDeveloperGuide.md#step-3-amazon-sends-you-the-authorization-information it looks like it varies slightly from what's currently available. To make it work there are some slight adjustments to be made configurable.

  • At a minimum be able to configure the expected authorization code parameter. Right now it is hard coded to code. As an example Amazon uses spapi_oauth_code. Ideally you can configure the expected parameter name for all the required parameters, but default to their current parameter keys.
  • Save additional parameters sent to the callback service. As an example shopify sends the shop, host and hmac. Amazon sends selling_partner_id and mws_auth_token.

Originally posted by @winklerj in #1213 (comment)

In the additional comments on this issue, it was noted that this does not conform to the OAuth standards, but Amazon and some other large providers have "custom implementations" that would be beneficial to support. This should be added to the OAuth support in the secret-service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant