Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preprocessor conditional error in gstutils #7846

Open
artificiel opened this issue Dec 31, 2023 · 2 comments
Open

preprocessor conditional error in gstutils #7846

artificiel opened this issue Dec 31, 2023 · 2 comments

Comments

@artificiel
Copy link
Contributor

I think the side-effect is that v 1.0-1.18 end up using the second form while the first form gets executed twice for 0.n (the bad #elseif simply gets ignored), which might not be a true bug (and might not happen often) but the conditional should be fixed anyway (I don't know if it's simpler to blanket 1.n with the second form as it seems harmless, of if the conditional should really be operational).

#elseif GST_VERSION_MINOR <= 18

@ofTheo
Copy link
Member

ofTheo commented Dec 31, 2023

ahh thanks @artificiel so is the fix then just changing it to #elif ?

@artificiel
Copy link
Contributor Author

yes that's the direct fix, but the WIP ambiance of the surrounding code (and the fact the error itself did not cause apparent trouble) made me wonder if a deeper look at the conditionals was warranted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants