Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to share a comparison or a list #3872

Open
1 of 3 tasks
Tracked by #4208 ...
teolemon opened this issue Mar 7, 2021 · 5 comments
Open
1 of 3 tasks
Tracked by #4208 ...

Allow to share a comparison or a list #3872

teolemon opened this issue Mar 7, 2021 · 5 comments

Comments

@teolemon
Copy link
Member

teolemon commented Mar 7, 2021

What

  • Allow to share a comparison from the Comparison mode by adding a Share this comparison button.
  • Allow to share lists from the List mode by adding a Share this list button.
  • Add a handling mechanism for Lists deep links to de-ambiguate between the 2

Web https://world.openfoodfacts.org/products/8024884500403,3263855093192,3045320001570,3021762383344,4008400402222,3330720237255,3608580823513,3700278403936,3302747010029,3608580823490,3250391660995,3760020506605,8722700202387,3330720237330,3535800940005,20000691,3270190127512

API

Note that it's also available as an API: https://world.openfoodfacts.org/api/v2/search?code=8024884500403,3263855093192&fields=code,product_name

Part of

@VaiTon
Copy link
Member

VaiTon commented Apr 7, 2021

Note that it's also available as an API: https://world.openfoodfacts.org/api/v2/search?code=8024884500403,3263855093192&fields=code,product_name

We should choose between using this for lists or using this for comparisons. Which one do we prefer and why?

@teolemon
Copy link
Member Author

teolemon commented Apr 9, 2021

perhaps we could have a modal: Open in Comparison mode, Open as a list ?

@teolemon
Copy link
Member Author

teolemon commented Apr 9, 2021

This might also greatly simplify screenshot automation

@teolemon teolemon changed the title Allow to share a comparison Allow to share a comparison or a list Aug 31, 2021
@priyanshu029
Copy link

Hello @teolemon can i work on this issue

@VaiTon
Copy link
Member

VaiTon commented Dec 31, 2022

@priyanshu029 sure you can, I'm assigning you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants