Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong flag set for group in non-root users #41

Closed
alexellis opened this issue Jul 6, 2018 · 2 comments · Fixed by #42, #43 or #45 · May be fixed by #44
Closed

Wrong flag set for group in non-root users #41

alexellis opened this issue Jul 6, 2018 · 2 comments · Fixed by #42, #43 or #45 · May be fixed by #44
Assignees
@ivanayov

Comments

@alexellis
Copy link
Member

This line in the Node template is incorrect according to the man/help page for busybox:

RUN addgroup -S app && adduser -S -g app app

-g must be G

/ # adduser
BusyBox v1.27.2 (2017-12-12 10:41:50 GMT) multi-call binary.

Usage: adduser [OPTIONS] USER [GROUP]

Create new user, or add USER to GROUP

        -h DIR          Home directory
        -g GECOS        GECOS field
        -s SHELL        Login shell
        -G GRP          Group
        -S              Create a system user
        -D              Don't assign a password
        -H              Don't create home directory
        -u UID          User id
        -k SKEL         Skeleton directory (/etc/skel)

Impact is unknown but should be fixed as soon as possible.

Expected Behaviour

app should belong to app group

Current Behaviour

app doesn't belong to the group

Possible Solution

Fix flag in all/any templates including ARM.

This will need testing too.
alexellis added a commit that referenced this issue Jul 6, 2018
@alexellis
Fix group for Node
0be5922 
See #41 for more details. Before: added GEO data for user, after
adds group to user.

Signed-off-by: Alex Ellis (VMware) <alexellis2@gmail.com>
@alexellis
Copy link
Member Author

(I've updated the node template)

ivanayov added a commit to ivanayov/templates that referenced this issue Jul 9, 2018
@ivanayov
Fix user group for Python
aeb61ff 
This fixes all python templates to set app group properly. Fixes
[openfaas#41](openfaas#41). Before
used to add GEO data for user, after the change adds group to user

Signed-off-by: Ivana Yovcheva (VMware) <iyovcheva@vmware.com>
@ivanayov ivanayov mentioned this issue Jul 9, 2018
Merged
11 tasks
ivanayov added a commit to ivanayov/templates that referenced this issue Jul 9, 2018
@ivanayov
Fix user group for Ruby
18e60ab 
This fixes ruby template to set app group properly. Fixes
[openfaas#41](openfaas#41). Before
used to add GEO data for user, after the change adds group to user

Signed-off-by: Ivana Yovcheva (VMware) <iyovcheva@vmware.com>
@ivanayov ivanayov mentioned this issue Jul 9, 2018
Merged
11 tasks
ivanayov added a commit to ivanayov/templates that referenced this issue Jul 9, 2018
@ivanayov
Fix user group for Golang
b81163b 
This fixes Go template to set app group properly. Fixes
[openfaas#41](openfaas#41). Before
used to add GEO data for user, after the change adds group to user

Signed-off-by: Ivana Yovcheva (VMware) <iyovcheva@vmware.com>
@ivanayov ivanayov mentioned this issue Jul 9, 2018
Open
11 tasks
ivanayov added a commit to ivanayov/templates that referenced this issue Jul 9, 2018
@ivanayov
Fix user group for dockerfile
7a848da 
This fixes dockerfile template to set app group properly. Fixes
[openfaas#41](openfaas#41). Before
used to add GEO data for user, after the change adds group to user

Signed-off-by: Ivana Yovcheva (VMware) <iyovcheva@vmware.com>
@ivanayov ivanayov mentioned this issue Jul 9, 2018
Merged
11 tasks
@ivanayov
Copy link
Contributor

ivanayov commented Jul 9, 2018

C# template is setting the group properly

@ivanayov ivanayov mentioned this issue Jul 9, 2018
Merged
11 tasks
alexellis pushed a commit that referenced this issue Jul 17, 2018
@ivanayov @alexellis
Fix user group for Ruby
e12758a 
This fixes ruby template to set app group properly. Fixes
[#41](#41). Before
used to add GEO data for user, after the change adds group to user

Signed-off-by: Ivana Yovcheva (VMware) <iyovcheva@vmware.com>
alexellis pushed a commit that referenced this issue Jul 17, 2018
@ivanayov @alexellis
Fix user group for Python
022f810 
This fixes all python templates to set app group properly. Fixes
[#41](#41). Before
used to add GEO data for user, after the change adds group to user

Signed-off-by: Ivana Yovcheva (VMware) <iyovcheva@vmware.com>
alexellis pushed a commit that referenced this issue Jul 24, 2018
@ivanayov @alexellis
Fix user group for dockerfile
2b46a3e 
This fixes dockerfile template to set app group properly. Fixes
[#41](#41). Before
used to add GEO data for user, after the change adds group to user

Signed-off-by: Ivana Yovcheva (VMware) <iyovcheva@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanayov ivanayov

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ivanayov @alexellis