Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python twisted 23.10 #776

Open
jbleyel opened this issue Jan 23, 2024 · 6 comments
Open

python twisted 23.10 #776

jbleyel opened this issue Jan 23, 2024 · 6 comments

Comments

@jbleyel
Copy link

jbleyel commented Jan 23, 2024

Please add python3-twisted_23.10.0.bb to master

Thanks

@gudnimg
Copy link

gudnimg commented Apr 1, 2024

Just adding that 24.3.0 has been released meanwhile: https://github.com/twisted/twisted/releases

@kraj
Copy link
Contributor

kraj commented Apr 1, 2024

Thanks, I think we need someone to draft a PR with upgrade PR

@gudnimg
Copy link

gudnimg commented Apr 13, 2024

I've been looking into what needs to change to upgrade the recipe the past weeks. So far it builds fine on my end using Kirkstone. But I think it is time to do some cleanup in the recipe.

FILES:${PN}-core for example is referencing non-existing files like ${libdir}/${PYTHON_DIR}/site-packages/twisted/python/timeoutqueue.py* \ which was removed in Twisted 10.2.0 :) I would have thought Bitbake raises an error, but apparently not.

@gudnimg
Copy link

gudnimg commented Apr 13, 2024

In case no one updates Twisted before I submit a patch I will try to do this with two patches:

  • Patch 1: Cleanup the current Twisted 22.10.0 recipe by mainly removing pointless FILES entries
  • Patch 2: only add necessary changes to update Twisted from 22.10.0 to 24.3.0

I have the changes already, just need to separate them into two commits. Will probably finish it tomorrow or over the next week.

@gudnimg
Copy link

gudnimg commented Apr 18, 2024

Just sent the final patch for review which upgrades twisted to 24.3.0 :)

@jbleyel
Copy link
Author

jbleyel commented Apr 18, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants