Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xscreensaver: why are glx hacks disabled? #734

Open
argosphil opened this issue Aug 22, 2023 · 1 comment
Open

xscreensaver: why are glx hacks disabled? #734

argosphil opened this issue Aug 22, 2023 · 1 comment

Comments

@argosphil
Copy link

argosphil commented Aug 22, 2023

I stumbled across this while playing with OpenGL on an embedded device:

-SUBDIRS = utils jwxyz hacks/images hacks hacks/glx hacks/fonts \
- driver po
+SUBDIRS = utils jwxyz hacks/images hacks hacks/fonts \
+ driver

The commit removes the hacks/glx directory without explanation. Was that by mistake? I've tried and while the recipe needed some adjustment in my case, the GLX hacks work fine once reenabled by undoing part of that patch.

[edited to expand the included snippet)

@kraj
Copy link
Contributor

kraj commented Aug 22, 2023

@argosphil its an oversight, only po generation is supposed to be removed by this patch. Can you submit your changes to this patch to re-enable glx hacks a PR

PheeL79 pushed a commit to PheeL79/meta-openembedded that referenced this issue Aug 29, 2023
Changelog:
===========
Added:
-----------
 add ${BATS_TEST_TAGS[@]} for querying the tags during a test (openembedded#705)
 print tags on failing tests (openembedded#705)
 test for negative arguments to --jobs (openembedded#693)
 add tests for --formatter cat (openembedded#710)
 test coverage in CI (openembedded#718)
 Support for rush as alternative to GNU parallel (openembedded#729)
 add bats_pipe helper function for run that executes \| as pipes (openembedded#663)
 publish docker images to ghcr.io (additionally to Dockerhub) (openembedded#740)

Fixed:
---------
 fix run with options overwriting the value of i (openembedded#726, openembedded#727)
 fix ${BATS_TEST_NAMES[@]} containing only --tags instead of test name since Bats v1.8.0 (openembedded#705)
 fix run --keep-empty-lines counting trailing \n as (empty) new line (openembedded#711)
 fix short flag unpacker creating bogus command lines with valued flags (openembedded#732)
 fix formatter becoming confused with retries (openembedded#734)
 fix --gather-test-outputs-in fails on tests with / (openembedded#735)
 fix overriding date breaks --timing (openembedded#736)

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants