Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update all github actions #34708

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

irtazaakram
Copy link
Member

@irtazaakram irtazaakram commented May 7, 2024

@irtazaakram
Copy link
Member Author

#33942 (comment)

upload-artifact@v4 and download-artifact@v4 includes breaking changes. https://github.com/actions/upload-artifact/releases/tag/v4.0.0
Migration doc https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md

@irtazaakram
Copy link
Member Author

Needs to updated GitHub Actions runner

Current version: https://github.com/actions/runner/releases/tag/v2.288.1
Screenshot 2024-05-07 at 4 05 47 PM

Support for Node20 was added in https://github.com/actions/runner/releases/tag/v2.315.0
Latest version of runner https://github.com/actions/runner/releases/tag/v2.316.1

new GitHub Actions require runner to updated to support node 20.

@irtazaakram irtazaakram marked this pull request as ready for review May 22, 2024 06:10
@@ -9,20 +9,21 @@ on:
jobs:
collect-and-verify:
if: (github.repository == 'edx/edx-platform-private') || (github.repository == 'openedx/edx-platform' && (startsWith(github.base_ref, 'open-release') == false))
runs-on: [ edx-platform-runner ]
runs-on: [ "ubuntu-20.04" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Will be great if we could centralize the ubuntu versions into a constants file or in some open-edx-setup-action

.github/workflows/unit-tests.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update GitHub Actions
2 participants