This repository has been archived by the owner on May 6, 2024. It is now read-only.
fix: Add Support For Hours, Minutes and Seconds in Dates #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saeedbashir
approved these changes
Apr 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LEARNER-9936
Implemented support for hours, minutes, and seconds in dates to prevent calendar synchronization update alerts when replacing the production application with the new codebase.
Prior to merging this PR, all calendar events were being added to the mobile native calendar at the timestamp of 04:00AM to 05:00AM because we were previously disregarding hours, minutes, and seconds. Therefore, we are now taking them into account, ensuring that calendar events are added at the exact time received from the backend.
How to test this PR
We can assess it by observing the behavior of the production application and then comparing it with the behavior on this branch.