Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push the docker images built by ods-quickstarters to DockerHub so we can reuse them when building ODS Boxes. #836

Open
victorpablosceruelo opened this issue Aug 17, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@victorpablosceruelo
Copy link
Contributor

Is your feature request related to a problem? Please describe.
No, it is not related to a problem.
When the docker images are built by the GitHub actions, please upgrade resulting images to the DockerHub account ( https://hub.docker.com/u/opendevstackorg ), so we can reuse them when building ODS Boxes and reduce time spent in that task (about 5h 30m right now).

Describe the solution you'd like
When the docker images are built for the branches master, 4.x, etc, push them to GitHub with the expected tag (latest, 4.x, etc).

Describe alternatives you've considered

  • Using the repository created by Sergio
    https://github.com/opendevstack/ods-docker-images
    which is not working (yet?) and forces us to have in another repository the Dockerfiles. We think they should be here.
  • Using docker cache mechanisms, which can not be used because building is done by oc and not directly by docker.
  • Reuse the previously created ODS Box and build it incrementally. This could lead us to future problems if upgrades are not done well. Not recommended.

Additional context
For this to work, we need username/password for the DockerHub account, which are currently in other repositories like ods-core, ods-provisioning-app, ods-document-generation-svc, ...
See: https://hub.docker.com/u/opendevstackorg

@victorpablosceruelo victorpablosceruelo added the enhancement New feature or request label Aug 17, 2022
@tbugfinder
Copy link
Contributor

Well, what does an „admin user“ expect of an image tagged 4.x? Is it a build of latest released version or a build of latest commit? I’d think we should have a clearer view about the meaning of a 4.x tag and the purpose of image builds.

@victorpablosceruelo
Copy link
Contributor Author

Hi @tbugfinder
You're right. This needs to be clear before going on with the task.

But there is something more: tailor is used to inject values into Build Config files ( bc.yml ) used by oc to generate docker images.
Since this bc.yml files are used to build docker images, that images have a lot of "static" parameters inside.
This means the images cannot be reused without recompilation.
Some examples of parameters are the proxy configuration or the nexus url.

If we do not change the way the docker images use that parameters, we cannot do what we propose in this issue without having problems.
Right now this is a blocker for implementing this enhancement... :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants