Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable StatefulSet #1108

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Enable StatefulSet #1108

wants to merge 14 commits into from

Conversation

serverhorror
Copy link
Contributor

fix #1107

output resources fetched from getRolloutData for debugging

/CC @clemensutschig, @dvvanessastoiber

@serverhorror serverhorror marked this pull request as ready for review May 8, 2024 14:59
metmajer
metmajer requested changes May 8, 2024
View reviewed changes
Copy link
Member

@metmajer metmajer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@serverhorror Thanks, Martin! Please change the protected final field AbstractDeploymentStrategy.DEPLOYMENT_KINDS to protected only and amend it in the HelmDeploymentStrategy class. I also suggest you introduce a new field OpenShiftService.STATEFULSET_KIND vs. using an in-line String 'StatefulSet'.

@serverhorror
Copy link
Contributor Author

@metmajer hope I fixed that in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafarre-bi jafarre-bi jafarre-bi requested changes

@metmajer metmajer metmajer requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support StatefulSet in Helm charts
4 participants
@serverhorror @metmajer @jafarre-bi @dvvanessastoiber