Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordrv production fix #1093

Closed

Conversation

serverhorror
Copy link
Contributor

@serverhorror serverhorror commented Apr 9, 2024

fix #1066
fix #1038
fix #1011

relates #1074, #1044, #1023

serverhorror and others added 30 commits July 24, 2023 12:04
This allows us to extract the relevant pod data
in case there are multiple pods in a mono-repo like rollout

fixes opendevstack#1011
fixes opendevstack#1011
This fixes an issue where the build bails out with:

```text
•	Task :codenarcMain FAILED
FAILURE: Build failed with an exception.
•	V/hat went wrong:
Execution failed for task ':codenarcMain'.
•	BUG! UNCAUGHT EXCEPTION: java.lang.invoke.MethodHandles$Lookup.<init>(java.lang.Class,int)
```
THIS IS AN UNRELATED CHANGE

It fixes:

```
Number of parameters in constructor of class org.ods.orchestration.util.DocumentHistoryEntry exceeds maximum allowed (5).
```
We are now more graceful in what we accept as valid in this test.
This removes the nested closures. The `obj.every { ... }` was incorrect anyway.
This also allows us to test more easily,
as we are not mixing data retrieval and data munging in the same method any more
…in-mono-repository-setup

# Conflicts:
#	src/org/ods/component/HelmDeploymentStrategy.groovy
(cherry picked from commit e4a6fe9)
…in-mono-repository-setup

# Conflicts:
#	CHANGELOG.md
#	src/org/ods/component/HelmDeploymentStrategy.groovy
#	src/org/ods/openshift/OpenShiftResourceMetadata.groovy
…nts-file-repeats-image-in-mono-repository-setup

# Conflicts:
#	CHANGELOG.md
That parameter was gone due to a previous change!
…in-mono-repository-setup

# Conflicts:
#	CHANGELOG.md
…in-mono-repository-setup

# Conflicts:
#	CHANGELOG.md
…charts-dependencies' into ordrv-production-fix

# Conflicts:
#	CHANGELOG.md
@serverhorror
Copy link
Contributor Author

Please see the original comment, this is a collection of all the mentioned issues/PRs.

This is so that the EDPiP tests run thru a state that actually exists in code at the time of merging and will test what ends up in master.

Once this is merge, everything mentioned here will be marked as merged as well, those are -- after all -- the same commits, just collected together.

fix #1066 fix #1038 fix #1011

relates #1074, #1044, #1023

@serverhorror serverhorror marked this pull request as ready for review April 9, 2024 12:09
@hrcornejo
Copy link
Contributor

We are going to integrate them separately

@hrcornejo hrcornejo closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants