Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request]: search only in selected version #41

Open
SimonGolms opened this issue Feb 11, 2020 · 7 comments
Open

[feature request]: search only in selected version #41

SimonGolms opened this issue Feb 11, 2020 · 7 comments

Comments

@SimonGolms
Copy link

I welcome the implementation of a search bar with PR #29. Unfortunately, it shows all results from all versions. As an end user I would have expected to see only the results from my selected version, which is per default the latest.

image

@tbugfinder
Copy link
Contributor

#59

@tbugfinder
Copy link
Contributor

@michaelsauter just curious - above screenshot includes "Components" at top right. Is this needed as it seems to be lost, too.

@tbugfinder
Copy link
Contributor

image

@michaelsauter
Copy link
Member

@tbugfinder No, the "components" bit was due to how the docs were organised prior to 2.x. Back then, all was categorised by repo, which is not ideal as for the user the repo structure doesn't really matter. Now we are free to organise the docs in any structure we think is most helpful.

@michaelsauter
Copy link
Member

Partially solved by #59. I'd still leave this issue open because a "search in selected version" would be the best default IMHO.

@tbugfinder
Copy link
Contributor

I don't think this is feasible right now comparing to antora or couchbase search result pages.
IMHO, grouping would be sufficient.

@tbugfinder
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants