-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ukrainian support: doesn't process Ї (yi) letter #42
Comments
What output woul'd you expect? Is "Ji" ok? |
I'd expect anything in ASCII, not cyrillic. I think 'Ji/ji' is possible option, better than keep it cyrillic. But I have to admit also that I couldn't figure out what is the source of transliteration system here. |
Hi Team! Thank you for your input. Here's a pull request with the fix: #43 @daubmannus: try it out and if it works I'll merged it in and prepare a v1.1.2 release. I made sure it works with different casing variations: >>> import cyrtranslit
>>> cyrtranslit.to_cyrillic("Ji", "ua")
'Ї'
>>> cyrtranslit.to_cyrillic("JI", "ua")
'Ї'
>>> cyrtranslit.to_cyrillic("ji", "ua")
'ї'
>>> cyrtranslit.to_cyrillic("jI", "ua")
'ї' |
installed cyrtranslit-1.1.1
echo 'Її' | cyrtranslit -l UA
output:
Ïï
(i.e. not changed)
The text was updated successfully, but these errors were encountered: