Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify/raise eror with stale NWP data. #26

Open
thomasarmstrong98 opened this issue Feb 22, 2023 · 0 comments
Open

Notify/raise eror with stale NWP data. #26

thomasarmstrong98 opened this issue Feb 22, 2023 · 0 comments

Comments

@thomasarmstrong98
Copy link
Member

thomasarmstrong98 commented Feb 22, 2023

Check that input NWP is not too far behind the inference datetime.

If the NWP data is stale and the model does not know this, then the forecasts will look wrong. For example if we perform inference at 3pm but the NWP data we supply from the database has init_time_utc of 5am, then the +4 hour forecast will be taking NWPs projected for 9am that morning rather than 7pm that night. A to do would be raise an error if the NWP data is too stale.

For example in gradboost_pv.inference.models.NationalBoostInferenceModel.check_incoming_data there can be a check for data.nwp.init_time_utc > data.inference_time - timedelta_threshold. Where timedelta_threshold is a configurable param.

@thomasarmstrong98 thomasarmstrong98 added bug Something isn't working and removed bug Something isn't working labels Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant