Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update database once Consumer is done #299

Open
peterdudfield opened this issue Sep 7, 2023 · 4 comments
Open

Update database once Consumer is done #299

peterdudfield opened this issue Sep 7, 2023 · 4 comments

Comments

@peterdudfield
Copy link
Contributor

Detailed Description

How to update the input_data_last_updated once a consumer has run.

Context

  • this table stores the most recent time the nwp, pv, sat, gsp, e.t.c has run
  • currently most consumer update the input_data_last_updated. see here
  • new NWP Consumer doesnt do this

Possible Implementation

  • add into new nwp consumer
  • add into dag to get it to do this, would need to give it DB_URL access
@peterdudfield
Copy link
Contributor Author

One to think about @devsjc

@devsjc
Copy link
Collaborator

devsjc commented Oct 4, 2023

I feel like this is one for the dag not the consumer - especially if all the various data import jobs are meant to update the table, one could envisage a task at the end of each relevant dag

@peterdudfield
Copy link
Contributor Author

yea, I'll try and write something and see how neat it looks in the dag

@devsjc
Copy link
Collaborator

devsjc commented Oct 4, 2023

Seems like less code duplication and seperation that way as well - one reuseable task vs several individual implementations in seperate microservices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants