-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuration with dotEnv/Environment variables #1231
Comments
I see that it will be some interesting work to make the application unaware of what "environment" it is running in. I don't see that it is possible to address configuration variables according to this documentation https://symfony.com/doc/3.4/configuration.html but it is mentioned in the documentation for 4.3, 4.4 and 5.0. Is this going to be an issue? |
It's not going to be an issue, just a little more work 😄 Symfony < 4 was using two different entrypoint for http requests, Let me know if you want a PR for any of that. |
@tdutrion Definitely interested in a PR for that |
I will let you push and merge the upgrade to Symfony 4 if you don't mind, that will help me greatly as the changes I will have to do include |
I have all the unit tests passing, and half the integration tests are failing with some weird error I do not understand but I will get that done in the next two weeks.
…On Fri, Nov 29, 2019, at 8:48 PM, Thomas Dutrion wrote:
I will let you push and merge the upgrade to Symfony 4 <https://twitter.com/grmpyprogrammer/status/1200524818686328833> if you don't mind, that will help me greatly as the changes I will have to do include `Symfony\Component\ErrorHandler\Debug` which is blocked by the current versions of other packages.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#1231?email_source=notifications&email_token=AAAG5IN2YF7IS3JQZGTIIYTQWHA7NA5CNFSM4JTDIYX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFPXG3Y#issuecomment-559903599>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAG5IKWTHS2YSDV5UE6ILLQWHA7NANCNFSM4JTDIYXQ>.
|
Any chance to help you with that weird error at all? |
Here's a sample of this error SYMFONY_DEPRECATIONS_HELPER=disabled vendor/bin/phpunit --testsuite integration tests/Integration/Infrastructure/Event/AuthenticationListenerTest.php Runtime: PHP 7.3.10 with Xdebug 2.7.1 Testing OpenCFP\Test\Integration\Infrastructure\Event\AuthenticationListenerTest Time: 1.28 seconds, Memory: 80.00 MB There were 9 errors:
/Users/chartjes/Sites/opencfp/vendor/symfony/stopwatch/Stopwatch.php:84
/Users/chartjes/Sites/opencfp/vendor/symfony/stopwatch/Stopwatch.php:84
/Users/chartjes/Sites/opencfp/vendor/symfony/stopwatch/Stopwatch.php:84
/Users/chartjes/Sites/opencfp/vendor/symfony/stopwatch/Stopwatch.php:84
/Users/chartjes/Sites/opencfp/vendor/symfony/stopwatch/Stopwatch.php:84
/Users/chartjes/Sites/opencfp/vendor/symfony/stopwatch/Stopwatch.php:84
/Users/chartjes/Sites/opencfp/vendor/symfony/stopwatch/Stopwatch.php:84
/Users/chartjes/Sites/opencfp/vendor/symfony/stopwatch/Stopwatch.php:84
/Users/chartjes/Sites/opencfp/vendor/symfony/stopwatch/Stopwatch.php:84 ERRORS! |
Description of the problem
Expected benefits
Offered solution
The text was updated successfully, but these errors were encountered: